Skip to content

refactor: remove @babel/plugin-proposal-function-bind #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2022
Merged

refactor: remove @babel/plugin-proposal-function-bind #1957

merged 4 commits into from
Oct 26, 2022

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 26, 2022 •
edited
Loading

PR Details

Description

This is a breaking change.

This PR remove remove @babel/plugin-proposal-function-bind for these reasons:

  1. This original proposal is dead yet, and the community are trying to re-design it, see:
  1. The re-designed proposals have reached stage-1, which provide different behaviors, so we want to stop using the legacy function-bind syntax.
  2. I think TypeScript/esbuild/swc will not support the legacy proposal, remove this can make it easier to switch to swc in the future.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 93440b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 160 packages
Name Type
@modern-js/babel-preset-base Patch
@modern-js/babel-preset-app Patch
@modern-js/babel-preset-lib Patch
@modern-js/core Patch
@modern-js/webpack Patch
@modern-js/plugin-testing Patch
@modern-js-app/eslint-config Patch
@modern-js/builder-webpack-provider Patch
@modern-js/babel-preset-module Patch
@modern-js/server-utils Patch
@modern-js/plugin-storybook Patch
@modern-js/plugin-router-legacy Patch
@modern-js/runtime Patch
@modern-js/app-tools Patch
tests Patch
api-service-koa Patch
testing-app Patch
@modern-js/plugin-jarvis Patch
@modern-js/eslint-config Patch
@modern-js/builder-plugin-esbuild Patch
@modern-js/builder-plugin-node-polyfill Patch
@modern-js/builder-plugin-swc Patch
webpack-builder-test Patch
@e2e/webpack-builder-basic Patch
@e2e/webpack-builder-ignore-css Patch
@e2e/webpack-builder-inline-chunk Patch
@modern-js/module-tools Patch
@modern-js/plugin-bff Patch
@modern-js/plugin-server Patch
@modern-js/server Patch
@modern-js/plugin-garfish Patch
@cypress-test/garfish-dashboard Patch
@cypress-test/garfish-main Patch
@cypress-test/garfish-table Patch
file-based-router Patch
@modern-js/plugin-tailwindcss Patch
@modern-js/plugin-nest Patch
@integration-test/alias-set Patch
async-entry-test Patch
bff-express Patch
basic-module Patch
composes-basic Patch
composes-external Patch
dev-module Patch
diff-suffix-module Patch
global-module Patch
prod-module Patch
css Patch
antd-less Patch
bad-nested-npm-import Patch
bad-npm-import Patch
base-import Patch
css-ts-declaration Patch
disable-source-map Patch
exclude-less Patch
exclude-sass Patch
import-common-css Patch
inline-css-url Patch
keep-css-url Patch
less-import Patch
less-inline-js Patch
less-npm-import Patch
multi-css Patch
multi-less Patch
multi-sass Patch
nested-npm-import Patch
npm-import Patch
single-css Patch
single-less Patch
single-sass Patch
tips-to-install-less-plugin Patch
twin-macro Patch
css-modules Patch
esbuild-minify-js Patch
always-inline Patch
always-url Patch
assets-in-css Patch
inline-limit Patch
tmp Patch
routes Patch
use-loader Patch
server-config Patch
server-prod Patch
simple Patch
init Patch
@modern-js/generator-plugin Patch
@modern-js/module-tools-v2 Patch
@modern-js/monorepo-tools Patch
@integration/module-tools-cli Patch
@integration/module-tools-build-config-bundleless Patch
@integration/module-tools-build-config Patch
@integration/module-tools-build-legacy Patch
@integration/module-tools-build-preset Patch
@integration/module-tools-build Patch
@modern-js/builder-shared Patch
@modern-js/builder Patch
@modern-js/css-config Patch
@modern-js/plugin-changeset Patch
@modern-js/plugin-esbuild Patch
@modern-js/plugin-i18n Patch
@modern-js/plugin-less Patch
@modern-js/plugin-proxy Patch
@modern-js/plugin-sass Patch
@modern-js/plugin-ssg Patch
@modern-js/new-action Patch
@modern-js/tsconfig Patch
@modern-js/bff-core Patch
@modern-js/bff-runtime Patch
@modern-js/server-core Patch
@modern-js/create-request Patch
@modern-js/plugin-egg Patch
@modern-js/plugin-express Patch
@modern-js/plugin-koa Patch
@modern-js/plugin-polyfill Patch
@modern-js/prod-server Patch
@modern-js/builder-doc Patch
@modern-js/create Patch
@modern-js/e2e Patch
@modern-js/node-bundle-require Patch
@modern-js/plugin Patch
@modern-js/types Patch
@modern-js/upgrade Patch
@modern-js/utils Patch
@modern-js/babel-compiler Patch
@modern-js/style-compiler Patch
@scripts/build Patch
@scripts/check-changeset Patch
@scripts/codemod Patch
@scripts/jest-config Patch
@scripts/lint-package-json Patch
@scripts/prebundle Patch
@scripts/vitest-config Patch
esbuild-integration Patch
@integration/module-tools Patch
runtime Patch
ssg Patch
ssr Patch
@modern-js/builder-website Patch
@modern-js/generator-common Patch
@modern-js/generator-utils Patch
@modern-js/entry-generator Patch
@modern-js/generator-generator Patch
@modern-js/module-generator Patch
@modern-js/monorepo-generator Patch
@modern-js/mwa-generator Patch
@modern-js/router-legacy-generator Patch
@modern-js/storybook-generator Patch
@modern-js/test-generator Patch
@modern-js/upgrade-generator Patch
@modern-js/generator-plugin-plugin Patch
@modern-js/repo-generator Patch
@modern-js/generator-cases Patch
@modern-js/base-generator Patch
@modern-js/bff-generator Patch
@modern-js/changeset-generator Patch
@modern-js/dependence-generator Patch
@modern-js/eslint-generator Patch
@modern-js/server-generator Patch
@modern-js/ssg-generator Patch
@modern-js/tailwindcss-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 55.72% // Head: 55.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (93440b1) compared to base (d0ff2bc).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1957      +/-   ##
==========================================
- Coverage   55.72%   55.72%   -0.01%     
==========================================
  Files         667      667              
  Lines       16874    16873       -1     
  Branches     3591     3591              
==========================================
- Hits         9403     9402       -1     
  Misses       6917     6917              
  Partials      554      554
Impacted Files Coverage Δ
packages/cli/babel-preset-base/src/plugins.ts 78.94% <ø> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanyuan0704 sanyuan0704 merged commit 27c0151 into web-infra-dev:next Oct 26, 2022
@chenjiahan chenjiahan deleted the remove_function_bind_plugin_1026 branch October 26, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanyuan0704 sanyuan0704 sanyuan0704 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @sanyuan0704